[node-core-library] Add support for alreadyExistsBehavior for symlinks and junctions
#2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D4N14L
requested review from
apostolisms,
halfnibble,
iclanton,
octogonz and
sachinjoseph
as code owners
D4N14L
changed the title
alreadyExistsBehavior for symlinks and junctionsalreadyExistsBehavior for symlinks and junctions
dmichon-msft
reviewed
Sep 2, 2021
dmichon-msft
approved these changes
Sep 2, 2021
|
@octogonz - let me know once you get a chance to test this so that we can get this merged, since it seems like a big hole in NCL. |
I should have some time tomorrow. |
|
Looking at this, I'm increasingly uncomfortable with the idea that |
octogonz
approved these changes
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for
alreadyExistsBehaviorfor symlinks and junctions to align with hardlinks. Additionally, fix various error scenarios that can be encountered for all types of links.Details
Support for
alreadyExistsBehaviorwas added for hardlinks in #2333, however it was not wired up for symlinks and junctions even though the options interface was used by these methods as well.Additionally, while adding support for these types of links, it was realized that there were a few error scenarios that were not being handled correctly:
AlreadyExistsBehavior.overwritewould delete the existing file but not create the new linkAlreadyExistsBehavior.overwritewould fail if the existing entity is a directory instead of a filelinkTargetPathmay or may not exist depending on the type of link being created, causing symlinks and junctions to non-existent files to fail (even though they are valid)How it was tested
Tested each link type in a local sandbox to probe error-handling scenarios, namely:
AlreadyExistsBehavior.overwrite